Code Review Request, JDK-8184316, Typo in javax.net.ssl.SSLServerSocket class documentation

Sean Mullan sean.mullan at oracle.com
Tue Jul 25 16:14:16 UTC 2017


SSLSocket has the same typo in its first sentence ("extends Sockets"), 
and should also say "provides secure sockets" (note the plural sockets). 
Can you fix that as part of this too?

One wording improvement below:

On 7/25/17 12:02 PM, Xuelei Fan wrote:
> Hi,
> 
> Please review the document typo update for:
>     https://bugs.openjdk.java.net/browse/JDK-8184316
> 
> The diff on javax/net/ssl/SSLServerSocket.java looks like:
> 
>   /**
> - * This class extends <code>ServerSocket</code>s and
> + * This class extends <code>ServerSocket</code> and
>    * provides secure server sockets using protocols such as the Secure
>    * Sockets Layer (SSL) or Transport Layer Security (TLS) protocols.
>    * <P>
> @@ -41,7 +41,7 @@
>    * is to create <code>SSLSocket</code>s by <code>accept</code>ing
>    * connections.
>    * <P>
> - * <code>SSLServerSocket</code>s contain several pieces of state data
> + * <code>SSLServerSocket</code> contains several pieces of state data

An SSLServerSocket contains ...

>    * which are inherited by the <code>SSLSocket</code> at
>    * socket creation.  These include the enabled cipher
>    * suites and protocols, whether client
> 
> Thanks,
> Xuelei


More information about the security-dev mailing list