RFR 8181841: A TSA server returns timestamp with precision higher than milliseconds

Michael StJohns mstjohns at comcast.net
Mon Jun 12 17:07:54 UTC 2017


On 6/12/2017 9:18 AM, Weijun Wang wrote:
>
>
> On 06/12/2017 08:47 PM, Vincent Ryan wrote:
>> This approach looks fine to me given the limitation on the precision 
>> of Date.
>> Just one issue: why remove the upper bound at l.277 in 
>> DerInputBuffer.java
>
> Before this fix, the maximum length of a GeneralizedTime is
>
> 20170101235555.123+0800
> 0---------1---------2--

The actual bound in GeneralizedTime is 6 digits of fractional time 
(according to ISO 8601) or
25 characters.  That should still continue to be enforced.




>
> Now that we allow arbitrary length of fractional part, there will be 
> no upper bound.
>
> --Max
>
>>
>> Thanks.
>>
>>
>>> On 12 Jun 2017, at 05:22, Weijun Wang <weijun.wang at oracle.com> wrote:
>>>
>>> Please review this fix at
>>>
>>>    http://cr.openjdk.java.net/~weijun/8181841/webrev.00
>>>
>>> So I just ignore the extra digits. Do you think this is OK? It does 
>>> mean different encodings might equal to each other.
>>>
>>> Thanks
>>> Max
>>




More information about the security-dev mailing list