JDK 9 RFR of JDK-8176182: 4 security tests are not run

Weijun Wang weijun.wang at oracle.com
Mon Mar 6 03:52:35 UTC 2017


Hi Amy

Change looks good.

BTW, how did you notice this?

Thanks
Max

On 03/06/2017 10:48 AM, Amy Lu wrote:
> sun/security/ec/SignedObjectChain.java
> sun/security/mscapi/SignedObjectChain.java
> sun/security/rsa/SignedObjectChain.java
> sun/security/ssl/rsa/SignedObjectChain.java
>
> These tests are not compile-only tests, but due to the missed @run tag,
> tests are not run.
>
> Please review the patch to add @run tag to them.
>
> Note that with the added @run tag, test result show that
> sun/security/mscapi/SignedObjectChain.java fails. Problem list it for now.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8176182
> webrev: http://cr.openjdk.java.net/~amlu/8176182/webrev.00/
>
> Thanks,
> Amy
>
> --- old/test/ProblemList.txt	2017-03-06 10:43:29.000000000 +0800
> +++ new/test/ProblemList.txt	2017-03-06 10:43:29.000000000 +0800
> @@ -215,6 +215,8 @@
>  javax/net/ssl/DTLS/PacketLossRetransmission.java                8169086 macosx-x64
>  javax/net/ssl/DTLS/RespondToRetransmit.java                     8169086 macosx-x64
>
> +sun/security/mscapi/SignedObjectChain.java                      8176183 windows-all
> +
>  ############################################################################
>
>  # jdk_sound
> --- old/test/sun/security/ec/SignedObjectChain.java	2017-03-06 10:43:30.000000000 +0800
> +++ new/test/sun/security/ec/SignedObjectChain.java	2017-03-06 10:43:30.000000000 +0800
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -24,8 +24,9 @@
>  /*
>   * @test
>   * @bug 8050374
> - * @compile ../../../java/security/SignedObject/Chain.java
>   * @summary Verify a chain of signed objects
> + * @compile ../../../java/security/SignedObject/Chain.java
> + * @run main SignedObjectChain
>   */
>  public class SignedObjectChain {
>
> --- old/test/sun/security/mscapi/SignedObjectChain.java	2017-03-06 10:43:31.000000000 +0800
> +++ new/test/sun/security/mscapi/SignedObjectChain.java	2017-03-06 10:43:30.000000000 +0800
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -24,9 +24,10 @@
>  /*
>   * @test
>   * @bug 8050374
> + * @summary Verify a chain of signed objects
>   * @compile ../../../java/security/SignedObject/Chain.java
>   * @requires os.family == "windows"
> - * @summary Verify a chain of signed objects
> + * @run main SignedObjectChain
>   */
>  public class SignedObjectChain {
>
> --- old/test/sun/security/rsa/SignedObjectChain.java	2017-03-06 10:43:32.000000000 +0800
> +++ new/test/sun/security/rsa/SignedObjectChain.java	2017-03-06 10:43:31.000000000 +0800
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -24,8 +24,9 @@
>  /*
>   * @test
>   * @bug 8050374
> - * @compile ../../../java/security/SignedObject/Chain.java
>   * @summary Verify a chain of signed objects
> + * @compile ../../../java/security/SignedObject/Chain.java
> + * @run main SignedObjectChain
>   */
>  public class SignedObjectChain {
>
> --- old/test/sun/security/ssl/rsa/SignedObjectChain.java	2017-03-06 10:43:32.000000000 +0800
> +++ new/test/sun/security/ssl/rsa/SignedObjectChain.java	2017-03-06 10:43:32.000000000 +0800
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -24,8 +24,9 @@
>  /*
>   * @test
>   * @bug 8050374
> - * @compile ../../../../java/security/SignedObject/Chain.java
>   * @summary Verify a chain of signed objects
> + * @compile ../../../../java/security/SignedObject/Chain.java
> + * @run main SignedObjectChain
>   */
>  public class SignedObjectChain {
>
>
>



More information about the security-dev mailing list