[9] RFR 8180635: (doc) Clarify the compatibility and interoperability issue when using provider default values

Sean Mullan sean.mullan at oracle.com
Tue May 30 17:50:57 UTC 2017


Just a couple more comments, in this text in each class:

* <b>Java™
* Cryptography Architecture JDK Providers Documentation</b></a>
* document for information on the AlgorithmParameterGenerator defaults
* used by JDK providers.

Don't use bold (<b>) on the document name.

The words "Documentation" and "document" are redundant.

Drop the JCA part. The new guide in JDK 9 will not include that in the 
title. So, I suggest changing it to simply "JDK Providers", ex:

* <b>JDK Providers</b></a>
* document for information on the AlgorithmParameterGenerator defaults
* used by JDK providers.

--Sean

On 5/26/17 6:54 PM, Valerie Peng wrote:
> Sean,
> 
> Thanks for the wording suggestions.
> Webrev updated at: http://cr.openjdk.java.net/~valeriep/8180635/webrev.01/
> 
> Have a wonderful long weekend,
> Valerie
> 
> On 5/26/2017 5:48 AM, Sean Mullan wrote:
>> Just a couple of comments:
>>
>> - the same text is in KeyPairGeneratorSpi and 
>> AlgorithmParameterGeneratorSpi so we should add the warning in those 
>> classes too
>>
>> - we should add the same warning to javax.crypto.KeyGenerator and 
>> KeyGeneratorSpi
>>
>> - Please change "Oracle Providers" to "JDK Providers", since all of 
>> these providers are included in the JDK implementation, and we don't 
>> want to include "Oracle" in the javadocs. (Plus the name of this guide 
>> will be changed to "JDK Providers" at some point in the near future).
>>
>> - Suggest changing the sentence "Even ..." to "Additionally, the 
>> default value for a provider may change in a future version."
>>
>> - s/Thus/Therefore/
>>
>> --Sean
>>
>> On 5/23/17 10:13 PM, Valerie Peng wrote:
>>> Sean,
>>>
>>> Can you please review this javadoc-only changes for JDK 9?
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8180635
>>> Webrev: http://cr.openjdk.java.net/~valeriep/8180635/webrev.00/
>>>
>>> Thanks,
>>> Valerie
>>
>>
> 



More information about the security-dev mailing list