RFR 8191137: keytool fails to format resource strings for keys for some languages after JDK-8171319

[Weijun Wang]

> On Nov 14, 2017, at 7:40 PM, Severin Gehwolf <sgehwolf at redhat.com> wrote:
> 
> On Tue, 2017-11-14 at 18:47 +0800, Wang Weijun wrote:
>>> 在 2017年11月14日，18:02，Severin Gehwolf <sgehwolf at redhat.com> 写道：
>>> 
>>> This looks fine, but I wonder if a regression test would be in
>>> order.
>>> E.g. test/sun/security/tools/keytool/WeakAlg.java with
>>> -Duser.language=fr or some such.
>> 
>> But my change has not really fixed anything. It’s just a hint on how
>> to correctly translate the strings. The test you suggested would
>> still fail after this change. It might be useful when the French
>> translation is updated. 
> 
> Why can't this change update Resources_fr.java to include the correct
> position and then the test updated to also work in French? It's not
> really a localization change, but introduction of the correct position
> of the parameter.

I cannot be sure about the change, and there could be other places where similar change is needed. I'll leave it to the globalization team. This won't waste much time and they will be able to fix the problem in all releases at the same time.

In fact, I initially assign this bug to globalization directly, but they suggested me to add position labels into the English resources first so they can follow.

--<ax

> 
> A follow-up bug could then move all other resources to a model similar
> to Resources_fr.java?
> 
> Thanks,
> Severin