RFR[10] 8186057: TLS interoperability testing between different Java versions

sha.jiang at oracle.com sha.jiang at oracle.com
Tue Nov 28 07:36:56 UTC 2017


Hi Artem,

Could you please take a look this update: 
http://cr.openjdk.java.net/~jjiang/8186057/webrev.08/

> By the way, I just noticed that JdkUtils.supportECKey() method and 
> other return strings "true" and "false" instead of boolean values. 
> This looks a bit unusual and unnecessary.
The returned values from method supportECKey(), supportsSNI and 
supportsALPN are consumed by method attr(), which only accepts String 
value. The values are outputted to stdout.
Especially these supportXXX() methods are not used by other classes. So, 
I thought they could simply return String instead of boolean.
But now I change them to return boolean values, and accordingly modify 
method attr() to accept any type.

> Utils.java, line 146: it would be better to close the stream.
Fixed.

Best regards,
John Jiang



More information about the security-dev mailing list