RFR 8186931: jdk.security.jarsigner package is missing package summary

mandy chung mandy.chung at oracle.com
Tue Sep 5 23:17:09 UTC 2017


+1

Mandy

On 9/5/17 5:16 PM, Weijun Wang wrote:
> The package info for com.sun.security.jgss in jdk.security.jgss is also missing. The updated change looks like this (I omit the copyright header):
>
> src/jdk.jartool/share/classes/jdk/security/jarsigner/package-info.java:
>
> +/**
> + * This package defines APIs for signing jar files.
> + */
> +package jdk.security.jarsigner;
>
>
> src/jdk.jartool/share/classes/module-info.java:
> + * This module also defines APIs for signing JAR files.
>
>
> src/jdk.security.jgss/share/classes/com/sun/security/jgss/package-info.java:
>
> +/**
> + * This package defines classes and interfaces for the JDK extensions
> + * to the GSS-API.
> + */
> package com.sun.security.jgss;
>
>
> src/jdk.security.jgss/share/classes/module-info.java:
>
> /**
> - * Defines Java extensions to the GSS-API and an implementation of the SASL
> + * Defines JDK extensions to the GSS-API and an implementation of the SASL
>   * GSSAPI mechanism.
>
> Thanks
> Max
>
>> On Aug 31, 2017, at 11:10 PM, Sean Mullan <sean.mullan at oracle.com> wrote:
>>
>> On 8/31/17 4:49 AM, Weijun Wang wrote:
>>
>>> /**
>>> * This package contains the {@link jdk.security.jarsigner.JarSigner} API,
>>> * which backs the signing function of the {@code jarsigner} tool.
>>> */
>> I think you should say something about that this API can be used to sign JAR files. The fact that it is also used by jarsigner seems less important to mention in the package description. I suggest changing this to:
>>
>> "This package contains the {@link jdk.security.jarsigner.JarSigner} API which can be used to sign jar files."
>>
>> --Sean



More information about the security-dev mailing list