RFR 8187786: Many javax/net/ssl/DTLS tests failing

Weijun Wang weijun.wang at oracle.com
Fri Sep 22 00:41:55 UTC 2017


> On Sep 22, 2017, at 8:37 AM, Xuelei Fan <xuelei.fan at oracle.com> wrote:
> 
> Looks good.

Thanks. I'll wait for the test passing and push the change.

> 
> There are some wired Krb5 modules dependency even Krb5 is not used at all in the testing.  Anyway, we may want an improvement in the future.

My fix this time is a pure "perl -i -pe 's/one krb5/two/krb5/" run. I do see @modules in both TETS.properties and .java files everywhere, and think one would completely shadow the other. Some cleanup is needed.

Thanks
Max

> 
> Thanks,
> Xuelei
> 
> On 9/21/2017 5:25 PM, Weijun Wang wrote:
>> Hi All
>> I'm very sorry that my earlier change for JDK-8186884 made a lot of DTLS test failing. A new @modules tag was added to JGSS/krb5 tests, but I didn't realize DTLS tests are also using it.
>> Please take a review at
>>    http://cr.openjdk.java.net/~weijun/8187786/webrev.00/
>> It's quite long, but only contains 2 changes:
>> 1. Add a "@modules java.security.jgss/sun.security.jgss.krb5" tag to every file that already has @modules tag for JGSS internal packages, both .java and TEST.properties.
>> 2. Backout JDK-8187788, which disables SSL tests.
>> I'm running tests for jdk_security3 now.
>> Thanks
>> Max



More information about the security-dev mailing list