RFR 8200152: KerberosString should use UTF-8 by default

Roger Riggs Roger.Riggs at Oracle.com
Mon Apr 9 13:03:14 UTC 2018


Hi,

I've seen a variety of interpretations of non-standard input for parsing 
booleans and
it is likely to cause confusion across properties.

I'd prefer that we converge on the interpretation used in the 
Boolean.parseBoolean.
Which uses:  "true".equalsIgnoreCase(s);

Better yet, call Boolean.parseBoolean!  Will be compatible with the 
previous GetBooleanAction().

$.02, Roger


On 4/7/2018 10:53 PM, Xuelei Fan wrote:
> In the current implementation, the map of the property value looks like:
>    null    -> false;
>    ""      -> false;
>    "true"  -> true;
>    "false" -> false;
>    "not"   -> false
>
> For compatibility, I think you may only want to update the default 
> value: null or empty property value, otherwise the behavior does not 
> change.
>
>    null    -> true;
>    ""      -> true;
>    "true"  -> true;
>    "false" -> false;
>    "not"   -> false
>
> Per the update, "not" property means true.  It might not be an issue 
> in practice.  I will have you make the final decision. Otherwise, 
> looks fine to me.
>
> Xuelei
>
> On 3/22/2018 8:04 PM, Weijun Wang wrote:
>> Please take a review of the code change and CSR at
>>
>>     CSR: https://bugs.openjdk.java.net/browse/JDK-8200153
>>     webrev: http://cr.openjdk.java.net/~weijun/8200152/webrev.00/
>>
>> Thanks
>> Max
>>



More information about the security-dev mailing list