RFR (+CSR) 8201627: Kerberos sequence number issues

Valerie Peng valerie.peng at oracle.com
Tue Apr 24 22:08:53 UTC 2018


Hi Max,

Most changes look good. I have only some comments and questions (see below):

- InitSecContextToken.java, line 62: bad -> unrecognized?
- According to the class javadoc of various Token classes and Kerberos 
spec, the sequence number is 8-byte integer from header byte 8-15, but 
java int have only 4 bytes. The current code seems to assume the first 4 
bytes of the sequence number are always 0. For the sake of compliance 
and max inter-operability, maybe we should use long to store the 
sequence number?

CSR looks good to me.
Thanks,
Valerie



On 4/18/2018 10:40 AM, Weijun Wang wrote:
> Please take a review of this fix:
>
>     webrev: http://cr.openjdk.java.net/~weijun/8201627/webrev.00/
>     CSR: https://bugs.openjdk.java.net/browse/JDK-8201814
>
> Basically we fix some bugs and introduce a system property so we can interop with everyone.
>
> Thanks
> Max
>



More information about the security-dev mailing list