RFR: 8202419: Avoid creating Permission constants early

Alan Bateman Alan.Bateman at oracle.com
Mon Apr 30 12:47:41 UTC 2018


On 30/04/2018 13:25, Claes Redestad wrote:
> Hi,
>
> moving a couple of local permission constants to 
> sun.security.util.SecurityConstants ensures we delay and avoid loading 
> permission classes very early during bootstrap. Delaying load is 
> profitable since it's happening early enough (before 
> System.initPhase1) to contribute to delaying the initialization of VM 
> subsystems.
>
> Webrev: http://cr.openjdk.java.net/~redestad/8202419/open.00/
This looks okay to me.

Just a few nits - the comment from AccessibleObject has moved to 
SecurityConstants. I think it would be better to leave the comment in 
AccessibleObject, then you can just comment the SecurityConstants update 
with the class name so that it's consistent with the other constants. 
Also this class uses 4-space indent so best to keep that consistent too.

-Alan


More information about the security-dev mailing list