RFR: jdk8u : 8208583: Better management of internal KeyStore buffers

Seán Coffey sean.coffey at oracle.com
Fri Aug 3 12:49:44 UTC 2018


Whoops! Patching too fast. Yes- that field is redundant for jdk8u.

I've removed its use. Webrev updated in place.

Regards,
Sean.

On 03/08/18 12:14, Weijun Wang wrote:
> Why does PBEKey::new still have a useClear parameter then?
>
>> On Aug 3, 2018, at 6:49 PM, Seán Coffey <sean.coffey at oracle.com> wrote:
>>
>> Max,
>>
>> I've applied the same patch to jdk8u-dev. It's pretty much a straightforward port. Some small parts didn't apply cleanly since jdk8u doesn't involve use of Finalizer/Cleaner in some areas.
>>
>> i.e.
>>
>> around line 80 : src/share/classes/com/sun/crypto/provider/PBEKey.java
>> and in constructor of src/share/classes/sun/security/provider/KeyProtector.java
>>
>> http://cr.openjdk.java.net/~coffeys/webrev.8208583.8u/webrev/
>>
>> Would appreciate your review.
>>
>> -- 
>> Regards,
>> Sean.
>>




More information about the security-dev mailing list