[12] RFR 8193859: Allow user provided ObjectInputFilter in SealedObject and SignedObject

Roger Riggs roger.riggs at oracle.com
Tue Aug 7 14:57:27 UTC 2018


Hi Max,

It may be useful to include in the descriptions a reminder that if no 
ObjectInputFilter
is supplied the global filter is used.  Details in ObjectInputStream.

Typically, the @throws clauses that are not full sentences do not 
include a final period "."
For consistency with the existing javadoc, omit the "."
For example, SealedObject.java:191, 239, 240, 330
SignedObject.java: 128, 130, 229, 252, 253

While you are editing SealedObject.java: 143-145, please indent the 
continuation lines of @throws.

Are there any caveats on what the serial filter needs to allow when used 
in SealedObject or SignedObject?

Thanks, Roger


On 8/7/18 2:31 AM, Weijun Wang wrote:
> Please review the code change at
>
>     webrev: http://cr.openjdk.java.net/~weijun/8193859/webrev.00/
>
> where
>
>        JBS: https://bugs.openjdk.java.net/browse/JDK-8193859
>        CSR: https://bugs.openjdk.java.net/browse/JDK-8193887
>
> Thanks
> Max
>
>




More information about the security-dev mailing list