RFR 8209416: Refactoring GetPropertyAction calls in JGSS

Roger Riggs roger.riggs at oracle.com
Mon Aug 13 13:53:07 UTC 2018


Hi Max,

It might be useful to be a bit more consistent about putting the 
property name on
the same line as the privilegedGetProperty.
It would help finding/grepping for the targets of privileged actions.
For example, Grep would not find the one in 
sun/security/krb5/Config.java:824-825 or
sun/security/jgss/ProviderList.java:109 (due to the static field 
definition).

Just a thought..

Otherwise looks fine.

Roger



On 8/13/18 6:24 AM, Weijun Wang wrote:
> Please take a review at
>
>     http://cr.openjdk.java.net/~weijun/8209416/webrev.00/
>
> This is all about refactoring "AccessController.doPrivileged(new GetPropertyAction(x))" into "GetPropertyAction.privilegedGetProperty(x)".
>
> I've already introduced a new GetBooleanAction::privilegedGetProperty method.
>
> Noreg-cleanup.
>
> Thanks
> Max
>
>




More information about the security-dev mailing list