RFR 8209416: Refactoring GetPropertyAction calls in JGSS

Weijun Wang weijun.wang at oracle.com
Mon Aug 13 15:36:35 UTC 2018


And several AccessController.doPrivileged(new GetBooleanAction()) calls.

If you'd like me to fix them as well, I can change the bug synopsis a little.

Thanks
Max


> On Aug 13, 2018, at 11:33 PM, Weijun Wang <weijun.wang at oracle.com> wrote:
> 
> 
> 
>> On Aug 13, 2018, at 10:00 PM, Xue-Lei Fan <xuelei.fan at oracle.com> wrote:
>> 
>> Looks fine to me.
>> 
>> Did you notice other places that might need similar update as well in security components?
> 
> One "new GetPropertyAction()" at
> 
>    String property = AccessController.doPrivileged(
>            new GetPropertyAction("jdk.tls.namedGroups"));
> 
> But I haven't checked for doPrivileged(()->System.getProperty()) calls.
> 
> Thanks
> Max
> 
>> 
>> Thanks,
>> Xuelei
>> 
>> 
>> On 8/13/2018 3:24 AM, Weijun Wang wrote:
>>> Please take a review at
>>>   http://cr.openjdk.java.net/~weijun/8209416/webrev.00/
>>> This is all about refactoring "AccessController.doPrivileged(new GetPropertyAction(x))" into "GetPropertyAction.privilegedGetProperty(x)".
>>> I've already introduced a new GetBooleanAction::privilegedGetProperty method.
>>> Noreg-cleanup.
>>> Thanks
>>> Max
> 




More information about the security-dev mailing list