RFR 8209416: Refactoring GetPropertyAction calls in JGSS
Xue-Lei Fan
xuelei.fan at oracle.com
Tue Aug 14 13:32:21 UTC 2018
Thanks for the update!
On 8/13/2018 11:39 PM, Weijun Wang wrote:
> Updated webrev at
>
> http://cr.openjdk.java.net/~weijun/8209416/webrev.01/
>
> You can look at [1] to see what has changed. Mostly it's a case in other security libs. I also change the calling style to put property name in the same line as the getProperty() call, and inline the name if it was defined as a constant.
>
> You might want to double check on the change in TlsRsaPremasterSecretParameterSpec.java. I think I got it right.
>
Would you like remove the PROP_NAME field, and use its value directly?
Just a nit, need no more review from me.
Thanks,
Xuelei
> Thanks
> Max
>
> [1] http://cr.openjdk.java.net/~weijun/8209416/webrev.01/interdiff.patch.html
>
>> On Aug 14, 2018, at 3:24 AM, Xue-Lei Fan <xuelei.fan at oracle.com> wrote:
>>
>> It's nice to fix them if you'd like to.
>>
>> Thanks,
>> Xuelei
>>
>> On 8/13/2018 8:36 AM, Weijun Wang wrote:
>>> And several AccessController.doPrivileged(new GetBooleanAction()) calls.
>>> If you'd like me to fix them as well, I can change the bug synopsis a little.
>>> Thanks
>>> Max
>>>> On Aug 13, 2018, at 11:33 PM, Weijun Wang <weijun.wang at oracle.com> wrote:
>>>>
>>>>
>>>>
>>>>> On Aug 13, 2018, at 10:00 PM, Xue-Lei Fan <xuelei.fan at oracle.com> wrote:
>>>>>
>>>>> Looks fine to me.
>>>>>
>>>>> Did you notice other places that might need similar update as well in security components?
>>>>
>>>> One "new GetPropertyAction()" at
>>>>
>>>> String property = AccessController.doPrivileged(
>>>> new GetPropertyAction("jdk.tls.namedGroups"));
>>>>
>>>> But I haven't checked for doPrivileged(()->System.getProperty()) calls.
>>>>
>>>> Thanks
>>>> Max
>>>>
>>>>>
>>>>> Thanks,
>>>>> Xuelei
>>>>>
>>>>>
>>>>> On 8/13/2018 3:24 AM, Weijun Wang wrote:
>>>>>> Please take a review at
>>>>>> http://cr.openjdk.java.net/~weijun/8209416/webrev.00/
>>>>>> This is all about refactoring "AccessController.doPrivileged(new GetPropertyAction(x))" into "GetPropertyAction.privilegedGetProperty(x)".
>>>>>> I've already introduced a new GetBooleanAction::privilegedGetProperty method.
>>>>>> Noreg-cleanup.
>>>>>> Thanks
>>>>>> Max
>>>>
>
More information about the security-dev
mailing list