RFR11(s): 8207317: SSLEngine negotiation fail exception behavior changed from fail-fast to fail-lazy

Bradford Wetmore bradford.wetmore at oracle.com
Tue Aug 21 00:06:02 UTC 2018



On 8/20/2018 4:28 PM, Xue-Lei Fan wrote:
> SSLTransport.java
> -----------------
> line 173, nice to have 4 more indent white spaces.

Ok, I could go either way on this one.

> SSLEngineImpl.java
> ------------------
>   942   // If it wasn't a RuntimeException/SSLException, need to wrap it.
>   943   if (!(exc instanceof RuntimeException) &&
>   944           !(exc instanceof SSLException)) {
>   945       exc = getTaskThrown(exc);
>   946   }
>   947
>   948   throw (SSLException)exc;
> 
> In line 948, the exc could be RuntimeException.  Is it possible to throw 
> ClassCastException?

Good catch.

Corrected:

     http://cr.openjdk.java.net/~wetmore/8207317/webrev.01/

Brad


> Otherwise, looks fine to me.
> 
> Thanks,
> Xuelei
> 
> On 8/20/2018 1:33 PM, Bradford Wetmore wrote:
>>
>> Hi Xuelei,
>>
>> Please review this P1 bug blocking JDK11 RC:
>>
>>      https://bugs.openjdk.java.net/browse/JDK-8207317
>>      http://cr.openjdk.java.net/~wetmore/8207317/webrev.00/
>>
>> Proposed putback comment is inlined in the webrev.
>>
>> Bug analysis/fix explanation is in the last comment of the bug.
>>
>> Brad
>>



More information about the security-dev mailing list