RFR 8209829: SpnegoUnknownMech.java does not contain the SpnegoUnknownMech class

David Holmes david.holmes at oracle.com
Wed Aug 22 07:08:40 UTC 2018


Hi Max,

Thanks for fixing.

Reviewed.

David

> JDK-8186186 added a new test called SpnegoUnknownMech.java [1]. It was named SpnegoRejected.java but was renamed to the current name right before the push. The content still references the old name and therefore cannot run.
> 
> Please review the patch here:
> 
> diff --git a/test/jdk/sun/security/krb5/auto/SpnegoUnknownMech.java b/test/jdk/sun/security/krb5/auto/SpnegoUnknownMech.java
> --- a/test/jdk/sun/security/krb5/auto/SpnegoUnknownMech.java
> +++ b/test/jdk/sun/security/krb5/auto/SpnegoUnknownMech.java
> @@ -23,16 +23,16 @@
>  
>  /*
>   * @test
> - * @bug 8186186
> + * @bug 8186186 8209829
>   * @library /test/lib
> - * @compile -XDignore.symbol.file SpnegoRejected.java
> + * @compile -XDignore.symbol.file SpnegoUnknownMech.java
>   * @run main jdk.test.lib.FileInstaller TestHosts TestHosts
> - * @run main/othervm/fail -Djdk.net.hosts.file=TestHosts SpnegoRejected
> + * @run main/othervm/fail -Djdk.net.hosts.file=TestHosts SpnegoUnknownMech
>   */
>  
>  import sun.security.jgss.GSSUtil;
>  
> -public class SpnegoRejected {
> +public class SpnegoUnknownMech {
>  
>      public static void main(String[] args) throws Exception {
> 
> 
> This is my fault. I suggested the rename and had not carefully review the change. Sorry.
> 
> Thanks
> Max
> 
> [1] http://hg.openjdk.java.net/jdk/jdk/file/0e4d87cf6caf/test/jdk/sun/security/krb5/auto/SpnegoUnknownMech.java




More information about the security-dev mailing list