[RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

Baesken, Matthias matthias.baesken at sap.com
Mon Aug 27 14:25:05 UTC 2018


Hi Alan ,

> Will sun.net.util.SocketExceptions be changed to use the supporting
> class or is that a separate issue?
> 

I think this is a separate issue .

> In terms of approach then I think what you have is okay although I think
> we should try to find a better name than "SecuritySystemPropertyHelper"
> and also get feedback from security-dev on whether they would prefer it
> in the sun.security tree with the other classes security classes.

Suggestions are welcome , I  was a bit unsure about the name as well 😉 !

Thanks, Matthias


> -----Original Message-----
> From: Alan Bateman <Alan.Bateman at oracle.com>
> Sent: Montag, 27. August 2018 15:52
> To: Baesken, Matthias <matthias.baesken at sap.com>; Sean Mullan
> <sean.mullan at oracle.com>; Chris Hegarty <chris.hegarty at oracle.com>
> Cc: core-libs-dev at openjdk.java.net; security Dev OpenJDK <security-
> dev at openjdk.java.net>
> Subject: Re: [RFR] 8205525 : Improve exception messages during manifest
> parsing of jar archives
> 
> On 24/08/2018 15:52, Baesken, Matthias wrote:
> > Hello, I created another webrev :
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8205525.5/
> >
> > - use now  jarPath  instead of  jarpath  in the java security file
> > -  moved the parsing of the property  to a more general location (separate
> class jdk/internal/util/SecuritySystemPropertyHelper.java  )
> > -  read now  from the InputStream and check for error conditions *before*
> setting jarFilename    in the Manifest  constructor
> >
> Will sun.net.util.SocketExceptions be changed to use the supporting
> class or is that a separate issue?
> 
> In terms of approach then I think what you have is okay although I think
> we should try to find a better name than "SecuritySystemPropertyHelper"
> and also get feedback from security-dev on whether they would prefer it
> in the sun.security tree with the other classes security classes.
> 
> -Alan


More information about the security-dev mailing list