RFR 8201317: X25519/X448 code improvements (xs)
Xuelei Fan
xuelei.fan at oracle.com
Tue Aug 28 17:10:53 UTC 2018
As you are already there, would you mind describe the differences
between multByInt() and mult()?
For method description, the comment is normally start with "/**" for
javadoc friendly.
Previously, you have the comment:
// must work when a==r
Do you want to keep it somehow?
Otherwise, looks fine to me.
Xuelei
On 8/28/2018 9:58 AM, Adam Petcher wrote:
> I received some suggestions for improvements to the X25519/X448 code
> after the completion of the code review back in March. The improvements
> are some additional comments on methods and some rearranged expressions
> to prevent integer overflow. The change is very small, please review if
> you have 10 minutes to spare.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8201317
> Webrev: http://cr.openjdk.java.net/~apetcher/8201317/webrev.00/
>
More information about the security-dev
mailing list