RFR 8215643: Microbenchmarks for KeyAgreement and Cipher
Eric Caspole
eric.caspole at oracle.com
Thu Dec 20 22:28:32 UTC 2018
Hi Adam,
The iteration control annotations you are inheriting from the CryptoBase
don't seem too good for the couple of your new micros I had time to try,
it is too short for warmup so there is a lot of run to run variation and
it will be a pain if we later run them in the weeklies.
Otherwise they look fine. It's OK with me to add them now and we can fix
the iteration control to stabilize them after the break.
Eric
On 12/19/18 13:43, Adam Petcher wrote:
> Webrev: http://cr.openjdk.java.net/~apetcher/8215643/webrev.00/
> JBS: https://bugs.openjdk.java.net/browse/JDK-8215643
>
> Please review this enhancement that adds two new crypto microbenchmarks.
> See the JBS ticket for the motivation behind these new benchmarks. The
> Cipher benchmark nearly duplicates some existing AES benchmarks, though
> the measurement is done differently in order to also address
> JDK-8214800[1]. I didn't want to upset anything by removing the existing
> AES benchmarks, but I'm interested in advice on how we should handle
> this duplication.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8214800
>
More information about the security-dev
mailing list