Code Review Request, JDK-8214418 HttpClient falls in running with 100% cpu usage after an error signalled on channel

Xue-Lei Fan xuelei.fan at oracle.com
Sat Dec 22 17:20:25 UTC 2018


Hi,

Could I get the update reviewed?
    http://cr.openjdk.java.net/~xuelei/8214418/webrev.00/

The reproducing testing case passed with the update.

The issue is caused by the handshake status "NEED_WRAP" while the 
connection is half-closed. An application may just call wrap() when the 
handshake status is "NEED_WRAP". For compatibility, I changed the 
handshake status from NEED_WRAP back to NOT_HANDSHAKING for inbound 
half-closed connection.  An application can use 
SSLEngine.isOutboundDone() for the determination if SSLEngine.wrap() 
should be called.

Thanks,
Xuelei





More information about the security-dev mailing list