RFR 6722928: Support SSPI as a native GSS-API provider

Weijun Wang weijun.wang at oracle.com
Sat Dec 29 02:20:56 UTC 2018


I redefine "new" to be "new (std::nothrow)" in the program.

Thanks,
Max

> On Dec 20, 2018, at 6:44 AM, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
> 
> Hi Max!
> 
> In sspi.cpp native memory is allocated via `new` or `new []`, and sometimes the returned pointer is checked for NULL.
> 
> If `new` fails, it will throw the `std:: bad_alloc` exception, so I believe you should use `new (std::nothrow)` and `new (std::nothrow) []` instead.
> 
> With kind regards,
> Ivan
> 
> On 11/19/18 5:56 PM, Weijun Wang wrote:
>> Please take a review at
>> 
>>    https://cr.openjdk.java.net/~weijun/6722928/webrev.01/
>> 
>> We ported [1] the native GSS bridge to Windows in JDK 11, but user still have to download and install a native GSS-API library. This code change provides a native GSS-API library inside JDK that can be used without setting the "sun.security.jgss.lib" system property. It is based on Windows SSPI and now only supports the client side using the default credentials.
>> 
>> No regression tests included. A Windows Active Directory server is needed.
>> 
>> Thanks
>> Max
>> 
>> [1] https://bugs.openjdk.java.net/browse/JDK-8200468
> 
> -- 
> With kind regards,
> Ivan Gerasimov
> 




More information about the security-dev mailing list