RFR (fix+CSR) 8196823: jarsigner should not create a signed jar if the signing fails

Sean Mullan sean.mullan at oracle.com
Tue Feb 6 21:18:05 UTC 2018


Looks good.

--Sean

On 2/6/18 4:39 AM, Weijun Wang wrote:
> Please review the following
> 
>    JBS: https://bugs.openjdk.java.net/browse/JDK-8196823
>    CSR: https://bugs.openjdk.java.net/browse/JDK-8196845
>    Fix: http://cr.openjdk.java.net/~weijun/8196823/webrev.00/
> 
> Some note:
> 
> 1. I copied the spec from InputStream:transferTo.
> 
> 2. In jarsigner.Main, error() calls exit(1), so the delete call cannot be put inside the finally block.
> 
> Thanks
> Max
> 


More information about the security-dev mailing list