[11] RFR: 8194486: Several krb5 tests failed in Mac.
Weijun Wang
weijun.wang at oracle.com
Fri Jan 19 08:17:29 UTC 2018
Remove principalProperty/TestHosts. Useless.
Remove 9999999 in @bug from AcceptPermissions.java. Don't know why it was there.
No need to modify BasicProc.java, ReplayCacheTestProc.java, rcache_usemd5.sh. These tests launches sub processes and will not see the system property.
Others look fine.
Thanks
Max
> On Jan 17, 2018, at 10:20 PM, Sibabrata Sahoo <sibabrata.sahoo at oracle.com> wrote:
>
> Hi Max,
>
> Here is an updated patch: http://cr.openjdk.java.net/~ssahoo/8194486/webrev.01/
>
> I found there are few more Test files which need the similar change as applicable to all other Test files in "sun/security/krb5/auto" folder. The change is applied to all Test files except the following 2 Test files inside the same folder.
>
> ReplayCacheExpunge.java
> ReplayCachePrecise.java
>
> Thanks,
> Siba
>
> -----Original Message-----
> From: Weijun Wang
> Sent: Thursday, January 11, 2018 11:33 AM
> To: Sibabrata Sahoo <sibabrata.sahoo at oracle.com>
> Cc: security-dev at openjdk.java.net
> Subject: Re: [11] RFR: 8194486: Several krb5 tests failed in Mac.
>
>
>
>> On Jan 11, 2018, at 1:30 PM, Sibabrata Sahoo <sibabrata.sahoo at oracle.com> wrote:
>>
>> I will remove the commented lines. I think, it should be fine, if I do not submit the webrev again.
>
> Not necessary at all.
>
> --Max
>
>>
>> Thanks,
>> Siba
>>
>> -----Original Message-----
>> From: Weijun Wang
>> Sent: Wednesday, January 10, 2018 9:07 PM
>> To: Sibabrata Sahoo <sibabrata.sahoo at oracle.com>
>> Cc: security-dev at openjdk.java.net
>> Subject: Re: [11] RFR: 8194486: Several krb5 tests failed in Mac.
>>
>> Code change looks fine. I think you can safely remove the lines commented out. If you meant to keep the history, the Mercurial repo already had it.
>>
>> Thanks
>> Max
>>
>>> On Jan 10, 2018, at 8:58 PM, Sibabrata Sahoo <sibabrata.sahoo at oracle.com> wrote:
>>>
>>> Hi,
>>>
>>> Please review the change for the following patch,
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8194486
>>> Webrev: http://cr.openjdk.java.net/~ssahoo/8194486/webrev.00/
>>>
>>> Description:
>>> There are several failure occurred recently because the name service used by these Tests were not determinable. This patch fixes those issues.
>>>
>>>
>>> Thanks,
>>> Siba
>>
>
More information about the security-dev
mailing list