RFR[11] JDK-8199645: javax/net/ssl/SSLSession/TestEnabledProtocols.java failed with Connection reset

sha.jiang at oracle.com sha.jiang at oracle.com
Wed Jul 11 02:52:03 UTC 2018


Hi Xuelei,
Thanks for your review!
The fix just was pushed.

I adjusted the following longer lines:
  129                 System.out.println("Client got UNEXPECTED 
SSLHandshakeException:");
  134                 System.out.println("Client got expected 
SSLHandshakeException:");

In addition, the parentheses, which encloses the new statement, also was 
removed.
  269         (new TestEnabledProtocols(
  270                 serverProtocols,
  271                 clientProtocols,
  272                 exceptionExpected,
  273                 selectedProtocol)).run();

Best regards,
John Jiang

On 2018/7/10 21:33, Xuelei Fan wrote:
> Looks fine to me.  Please limit each line in 80 characters.
>
> Thanks,
> Xuelei
>
> On 7/10/2018 2:27 AM, sha.jiang at oracle.com wrote:
>> Hi,
>> javax/net/ssl/SSLSession/TestEnabledProtocols.java may have some 
>> problem on sync between server and client.
>> And it would be better to refactor this test with 
>> SSLSocketTemplate.java.
>>
>> Webrev: http://cr.openjdk.java.net/~jjiang/8199645/webrev.00/
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8199645
>>
>> Best regards,
>> John Jiang
>>
>



More information about the security-dev mailing list