RFR [11] 8207846: Generalize the jdk.net.includeInExceptions security property

Roger Riggs roger.riggs at oracle.com
Fri Jul 20 14:36:54 UTC 2018

Hi Chris,

It is important to be clear about how whitespace is treated and within 
the java.security file
there are other uses that explicitly define how whitespace is used.

I am more concerned about how command line properties are understood and 
used how we have to document them.
Allowing whitespace quickly gets bogged down in how shells handle 
quotes, telling people they have to
quote them and when/whether you have to quote the quotes.

Having a consistent treatment of command line and security properties 
keeps the
story simple and easier to support.

The jdk.serialFilter property had the same issue and is explicit in the 
java.security file
that spaces are just another character and are not treated specially.

Its a slippery slope, if we start compensating/ignoring whitespace in 
some properties
then we will have to keep explaining how some are treated differently.
I would keep the original non-whitespace description.
Case-insensistive compares are another slippery slope but make a bit 
more sense for usability.

$.02, Roger

On 7/20/18 10:18 AM, Chris Hegarty wrote:
> Roger,
>> On 20 Jul 2018, at 14:52, Roger Riggs <roger.riggs at oracle.com> wrote:
>> Hi Chris,
>> It is very unusual for the processing of system properties to do *any* parsing except for delimiters
>> including removing spaces, etc.  It complicates the handling and sets a bad precedent
>> that makes it more complex for users and developers to know how to set property values.
>> The whitespace trimming should be removed.
> The addition of the whitespace trimming was to clarify the intent of
> the existing wording regarding whitespace. It was not intended to
> set a precedent, good or bad.
> Regardless of any subjective opinion, whitespace are allowable
> within system property values, so it’s a matter of whether or not
> we want to deal with them explicitly or just leave it as an
> implementation detail.
> I’m ok to drop the trimming if you feel strongly about it. But just
> to note that this now diverges even more from the original.
> -Chris.
>> $.02, Roger
>>>    http://cr.openjdk.java.net/~chegar/8207846/webrev.00/
>>> -Chris.
>>> P.S. It appears that jtreg does not support quoted system property values
>>> with spaces on the @run line. I’ll file an issue against jtreg for this.

More information about the security-dev mailing list