Code Review Request: TLS 1.3 Implementation

[Xuelei Fan]

 > http://hg.openjdk.java.net/jdk/sandbox/rev/50595f26ea8a

SSLEngineImpl.java:
-------------------
- return new SSLEngineResult(Status.OK, getHandshakeStatus(), 0, 0);
+ return new SSLEngineResult(Status.BUFFER_UNDERFLOW,
                                         getHandshakeStatus(), 0, 0);

As the handshake status has been retrieved in "hsStatus" in previous 
code, could we just use "hsStatus" rather than call getHandshakeStatus() 
again?

   return new SSLEngineResult(Status.BUFFER_UNDERFLOW, hsStatus, 0, 0);

Xuelei


On 6/1/2018 7:16 AM, Adam Petcher wrote:
> On 5/25/2018 7:45 PM, Xuelei Fan wrote:
> 
>> Here is the webrev:
>>     http://cr.openjdk.java.net/~xuelei/8196584/webrev-full.00
> 
> Small update: http://hg.openjdk.java.net/jdk/sandbox/rev/50595f26ea8a
> 
> This fixes a SSLEngine bug in which a result status of OK is returned 
> (instead of the expected BUFFER_UNDERFLOW) from unwrap when the input 
> buffers are empty.
> 
> Note to reviewers: This change (along with other small updates like 
> this) will be included in a future webrev that is published as a part of 
> this code review.