RFR JDK-8178374: Problematic ByteBuffer handling in CipherSpi.bufferCrypt method

Anthony Scarpino anthony.scarpino at oracle.com
Fri Jun 8 18:22:05 UTC 2018


On 06/06/2018 02:16 PM, Valerie Peng wrote:
> Hi Tony,
> 
> Can you please help reviewing this fix? The original impl uses buffering 
> for both input and output and is broken in several places. I ended up 
> re-writing most of them. The buffering is done only on input. The new 
> regression test covers all 4 combination of input/output ByteBuffers as 
> well as various sizes.
> 
> Webrev: http://cr.openjdk.java.net/~valeriep/8178374/webrev.00/
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8178374
> 
> Thanks,
> Valerie


The change looks fine to me.

Thanks

Tony



More information about the security-dev mailing list