RFR[11] JDK-8205720 "KeyFactory#getKeySpec and translateKey thorws NullPointerException with Invalid key"

Xuelei Fan xuelei.fan at oracle.com
Fri Jun 29 18:35:36 UTC 2018


Looks fine to me.

Thanks,
Xuelei

On 6/29/2018 11:30 AM, Valerie Peng wrote:
> Xuelei,
> 
> Can you please help reviewing this fix for JCK test failures? 
> Essentially, the JCK tests use key created with null algorithm, 
> encoding, and format for triggering InvalidKeyException. However, the 
> SunRsaSign provider code throw NPE so test failures are observed. Null 
> checks are added to various places to detect and check 
> InvalidKeyException instead. Fixes have been verified against the failed 
> JCK tests.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8205720
> Webrev: http://cr.openjdk.java.net/~valeriep/8205720/webrev.00/
> 
> Thanks,
> Valerie
> 



More information about the security-dev mailing list