RFR JDK-8199388: Test development for ChaCha20 and Poly1305 algorithms
Sean Mullan
sean.mullan at oracle.com
Mon May 7 19:58:28 UTC 2018
- test/lib/jdk/test/lib/Utils.java
402 * @param bytes Byte array to process
Nit, but you should keep the previous version where "byte" was not
capitalized. Typically, sentence fragments in javadoc like this are not
capitalized, and "Byte" can be confused with java.lang.Byte which this
is not.
403 * @return Space separated hexadecimal string representation of
bytes
Based on previous comment, this should be "space".
Looks fine otherwise.
--Sean
On 4/23/18 9:16 PM, sha.jiang at oracle.com wrote:
> Hi,
> This patch only adds a test for ChaCha20 key generator.
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8199388
> Webrev: http://cr.openjdk.java.net/~jjiang/8199388/webrev.00/
>
> Best regards,
> John Jiang
>
More information about the security-dev
mailing list