RFR 8201815: Use Mozilla Public Suffix List
Weijun Wang
weijun.wang at oracle.com
Wed May 23 00:01:53 UTC 2018
> On May 23, 2018, at 4:21 AM, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:
>
> ... but you should switch order on the chmod and the mv in the new gensrc file, so the mv comes last.
I thought it's safer to call CHMOD last so MV won't change file mode back. (I'm not saying it will, just afraid.)
In below cases, CHMOD is called after MV/CP.
gendata/Gendata-java.base.gmk
59- $(MV) $@.tmp $@
60: $(CHMOD) 444 $@
61-
common/JavaCompilation.gmk
80- $(CP) $$< $$@
81: $(CHMOD) -f ug+w $$@
Thanks
Max
>
> /Magnus
>
>> 22 maj 2018 kl. 17:44 skrev Erik Joelsson <erik.joelsson at oracle.com>:
>>
>> Build changes look ok.
>>
>> /Erik
>>
>>
>>> On 2018-05-22 08:25, Weijun Wang wrote:
>>> Please take a review at
>>>
>>> http://cr.openjdk.java.net/~weijun/8201815/webrev.00/
>>>
>>> With this change, We switch from a home-grown public suffix list (implemented in sun/net/RegisteredDomain.java) to Mozilla's PSL. The PSL data was re-encoded as a zip file with entries for different TLDs.
>>>
>>> There is no plan to update the data in a different channel other than a JDK release.
>>>
>>> Thanks
>>> Max
>>>
>>
>
More information about the security-dev
mailing list