A new proposal to add methods to HttpsURLConnection to access SSLSession

Sean Mullan sean.mullan at oracle.com
Fri Nov 9 13:19:59 UTC 2018


On 11/8/18 4:06 PM, Xuelei Fan wrote:
> To make sure the SecureCacheResponse class work, two new tests are added 
> (DefaultCacheResponse for default implementation, DummyCacheResponse for 
> a test implementation):
>      http://cr.openjdk.java.net/~xuelei/8212261/webrev.04/

I think you mean http://cr.openjdk.java.net/~xuelei/8212261/webrev.05/

Looks good.

--Sean

> 
> Thanks,
> Xuelei
> 
> On 11/8/2018 7:03 AM, Sean Mullan wrote:
>> On 11/7/18 7:22 PM, Xuelei Fan wrote:
>>> On 11/7/2018 1:30 PM, Sean Mullan wrote:
>>>>>    https://bugs.openjdk.java.net/browse/JDK-8213161
>>>>>    http://cr.openjdk.java.net/~xuelei/8212261/webrev.03/
>>>>
>>>> I didn't see a test for SecureCacheResponse - is it possible?
>>> JDK does not have the reference implementation of SecureCacheResponse.
>>
>> Ah, I see. I am sure there is a good reason, but why doesn't it have 
>> an implementation?
>>
>>>> You could also add a test case for IllegalStateExc.
>>>>
>>> Added in the same test file.
>>>
>>>> lines 108-113 of HttpsSession.java should be indented 4 more spaces. 
>>>> Otherwise looks ok to me.
>>>>
>>> Updated.
>>>
>>> New webrev:
>>> http://cr.openjdk.java.net/~xuelei/8212261/webrev.04/
>>
>> Looks good.
>>
>> --Sean


More information about the security-dev mailing list