Code Review Request : JDK-8213694 : Test Timeout.java should run in othervm mode

Jamil Nimeh jamil.j.nimeh at oracle.com
Fri Nov 9 17:17:48 UTC 2018


Looks fine to me.

On 11/9/2018 8:43 AM, Xuelei Fan wrote:
> Hi,
>
> Could I get the following small change reviewed please?
>    http://cr.openjdk.java.net/~xuelei/8213694/webrev.00/
>
> The test SSLSessionContextImpl/Timeout.java is running in the default 
> mode. As the test initializes the SSLContext with the current System 
> Properties, while the SunJSSE provider does not support dynamic System 
> Properties, this test may impact other test cases running in 
> samevm/agentvm mode.  The impact is very hard to debugging.
>
> I updated the test to run in othervm mode, and cleanup the code by 
> removing commented out codes and close the server socket with a 
> try-with-resource.
>
> Thanks,
> Xuelei




More information about the security-dev mailing list