[8u-dev] RFR JDK-8187218 & JDK-8131051, two krb5 fixes on renewable

Weijun Wang weijun.wang at oracle.com
Wed Sep 19 15:38:33 UTC 2018


Change looks fine, but the code style of lines 947-954 is quite different from normal, including, no space after keywords, wrong indentation of inner block and wrapped line, brace and else not on the same line, etc.

--Max

> On Sep 19, 2018, at 10:40 PM, Prasadrao Koppula <prasadarao.koppula at oracle.com> wrote:
> 
> Could you please review the following fixes for 8u-dev?
>  
> jbs: https://bugs.openjdk.java.net/browse/JDK-8187218, 
>        https://bugs.openjdk.java.net/browse/JDK-8131051
> webrev: http://cr.openjdk.java.net/~pkoppula/8187218/webrev.00/
>  
> Thanks,
> Prasad.K




More information about the security-dev mailing list