RFR: JDK-8210918, Add test to exercise server-side client hello processing

Xuelei Fan xuelei.fan at oracle.com
Fri Sep 21 23:15:40 UTC 2018


On 9/21/2018 4:00 PM, Jamil Nimeh wrote:
> Are you suggesting having multiple run lines or something like that?  I 
> think we could do that.
I would prefer to to the run lines.

> I would like to have it run all cases rather 
> than short-circuit on the first failure, as each case doesn't depend on 
> the others.
It should be fine to break earlier as normally the test should be passed.

> Let me play around with the run directives and see if we 
> can make it work more along the lines you want.
> 
Thanks!

Xuelei

> --Jamil
> 
> 
> On 09/21/2018 03:55 PM, Xuelei Fan wrote:
>> Once there is a test case failed, it may be not straightforward to 
>> identify which one is failed.  Especially, currently, the testing blog 
>> may be swallowed if it is too long.   Would you please consider one 
>> case per test?  Or break immediately if a test case failed, instead of 
>> waiting for all to complete?
>>
>> Thanks,
>> Xuelei
>>
>> On 9/21/2018 2:35 PM, Jamil Nimeh wrote:
>>> Hello all,
>>>
>>> This adds a test that lets us send different kinds of client hellos 
>>> to a JSSE server. It can be extended to handle different kinds of 
>>> corner cases for client hello extension sets as well as fuzzing test 
>>> cases in the future.  It also provides some extra test coverage for 
>>> JDK-8210334 and JDK-8209916.
>>>
>>> Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8210918/webrev.01/
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8210918
>>>
>>> Thanks and have a good weekend,
>>> --Jamil
> 



More information about the security-dev mailing list