RFR (S): 8213233: [TESTBUG] re-evaluate test/hotspot/jtreg/runtime/JVMDoPrivileged tests following JDK-8212605

[David Holmes]

Hi Sean,

On 2/04/2019 10:47 pm, Sean Mullan wrote:
> Hi David,
> 
> These tests still seem somewhat VM-specific to me. We don't have any 
> *.jasm files in our tests area. Are these tests even relevant anymore 
> now that doPriv is all-Java? The previous bug fix that introduced these 
> tests was entirely in the hotspot code and had to do with default 
> methods not being called in a PrivilegedAction instance. 

The existence of the bug shows that there were no existing functional 
tests for that particular usage scenario (else we'd have encountered it 
much sooner). But the bug was in VM functionality that would only be 
used in that one usage context. Now the code is in Java we're using the 
regular VM method lookup and selection processes which are of course 
being exercised by every test. In essence we're now relying on 
composition of two features (AccessController API and default methods) 
working correctly by virtue of each feature working correctly on its own.

> I would be more 
> inclined to just remove these tests unless there is some possibility 
> this could be an issue in Java code, but it seems like that would be a 
> more general issue then and not specific to doPriv because the Java code 
> just invokes PrivilegedAction.run() now.

Okay. I'll either delete it or keep it, but won't move it.

Thanks,
David

> --Sean
> 
> On 4/2/19 1:03 AM, David Holmes wrote:
>> Hi Security-libs team,
>>
>> webrev: http://cr.openjdk.java.net/~dholmes/8213233/webrev/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8213233
>>
>> Now that doPrivileged is Java-based these older runtime regression 
>> tests don't really belong in runtime any longer. I'd like to hg move 
>> them to test/jdk/java/security/AccessController
>>
>> Thanks,
>> David