RFR [13] JDK-8221882: Use fiber-friendly java.util.concurrent.locks in JSSE
Xuelei Fan
xuelei.fan at oracle.com
Wed Apr 3 19:33:41 UTC 2019
On 4/3/2019 12:06 PM, Alan Bateman wrote:
> On 03/04/2019 19:40, Xuelei Fan wrote:
>> Updated webrev (updated SSLContext.java, HttpsClient,
>> HttpsURLConnectionImpl):
>> http://cr.openjdk.java.net/~xuelei/8221882/webrev.01/
>>
> This looks good to me, the only change that I'm not 100% sure on is in
> HttpsClient where the locking will not be consistent with the locking in
> the HttpClient super class. Would you mind doubling checking that one?
> We do need to change the HTTP protocol handler so I expect HttpClient
> will change but it may have to add a protected lock that HttpsClient
> uses to ensure that they are using the same lock.
>
Hm, the update is problematic. Thanks for the catching!
It might be better to make the update together with other http code in
another enhancement. I'd like not update the HttpsClient update this time.
new webrev (remove update for HttpsClient.java):
http://cr.openjdk.java.net/~xuelei/8221882/webrev.02/
Thanks,
Xuelei
More information about the security-dev
mailing list