8219861: Add new keytool -tls command for displaying TLS configuration information

Weijun Wang weijun.wang at oracle.com
Thu Apr 4 03:15:43 UTC 2019


Webrev updated at

   https://cr.openjdk.java.net/~weijun/8219861/webrev.02

The "Disabled by Default" lists are removed. They could be a little confused.

Thanks,
Max

> On Apr 4, 2019, at 4:25 AM, Sean Mullan <sean.mullan at oracle.com> wrote:
> 
> On 3/28/19 8:20 AM, Weijun Wang wrote:
>> Please take a review at
>>    https://cr.openjdk.java.net/~weijun/8219861/webrev.01/
>> The ShowInfo::tls method is extracted from the JSSE Provider doc [1].
>> Noreg-other?
> 
> Seems ok, unless you want to add a test which adds or removes a suite from the enabled list and then make sure that they are displayed correctly.
> 
>  36     static void tls(boolean verbose) throws Exception {
> 
> verbose is never used.
> 
> 41         ArrayList<String> enabled = new ArrayList(
> 
> Missing "<>". Same comment on lines 44, 61, 64.
> 
> Also, you don't need to create the ArrayList for enabled since you are not removing from those lists. You can just do:
> 
>    List<String> enabled = Arrays.asList(ssls.getEnabledProtocols());
> 
>  48         System.out.println("Enabled by Default protocols");
> 
> I would capitalize "protocols" ("Protocols").
> 
> --Sean
> 
>> Thanks,
>> Max
>> [1] https://docs.oracle.com/en/java/javase/12/security/oracle-providers.html#GUID-7093246A-31A3-4304-AC5F-5FB6400405E2




More information about the security-dev mailing list