RFR 8222275: sun/security/tools/keytool/Serial64.java: assertTrue: expected true, was false

[Weijun Wang]

> On Apr 12, 2019, at 10:59 PM, Xuelei Fan <xuelei.fan at oracle.com> wrote:
> 
> To test a 3% or 10% chance of 64-bits serial number,

Can you explain what 3% or 10% you mean here?

> I don't think the test really make sense now.  I would prefer to drop this test, or just keep the positive value checking (one cert only).

...if it fails again. :-)

Thanks,
Max

> 
> If you want to keep it, the code looks good to me.
> 
> Xuelei
> 
> On 4/12/2019 12:59 AM, Weijun Wang wrote:
>> Please take a review at
>>  https://cr.openjdk.java.net/~weijun/8222275/webrev.00/
>> Now the test would generate 10 to 30 certs. It could still fail, but the probably is extremely small now (2^-30 is 10^-9).
>> And the test would succeed early if a 64 bit SN is found.
>> Thanks,
>> Max