[15] RFR 8236070: Multiple test failures after JDK-8234465

Sean Mullan sean.mullan at oracle.com
Tue Dec 17 12:52:55 UTC 2019


On 12/17/19 3:47 AM, Weijun Wang wrote:
> Multiple tests failed after my code change for including the public key into the encoded EC private key:
> 
>     https://bugs.openjdk.java.net/browse/JDK-8234465
>     https://hg.openjdk.java.net/jdk/jdk/rev/066bb54fba95
> 
> The reason is that while a newly generated ECPrivateKeyImpl (or one decoded from a PKCS #8 file already containing the public key info) has the public key info and can encode it in a PKCS #8 file, the ECPrivateKeySpec still does not have the related method so a private key created from KeyFactory will not have it, and key comparison tests like KeySpecTest.java and TestEC.java fail.
> 
> Therefore I'd like to revert the change in JDK-8234465 and think of a better way to resolve this issue. We might either compare the keys in a different way or introduce the getPublicKey method to more classes to make this info available everywhere.

Backing out the change is fine with me. I would suggest using a 
different title for the bug though, like "Backout fix for JDK-8234465."

--Sean

> 
> Thanks,
> Max
> 
> p.s. DefaultSignatureAlgorithm.java fails with a different reason.
> 



More information about the security-dev mailing list