RFR 8236470: Deal with ECDSA using ecdsa-with-SHA2 plus hash algorithm as AlgorithmId

Weijun Wang weijun.wang at oracle.com
Sat Dec 21 11:23:29 UTC 2019


Please take a review at

   http://cr.openjdk.java.net/~weijun/8236470/webrev.00/

The current implementation is not good at dealing with ECDSA specified by ecdsa-with-SHA2 plus a hash algorithm. While the AlgorithmId::getName is able to return the "full" signature algorithm name, it mutates the internal, cannot be guaranteed to be called, and leaves the parameters unchanged. This fix move the logic to AlgorithmId::parse and the class becomes practically immutable.

For Oracle internal reviewers: An update is made to the test also. The closed path has been wrong since the repo consolidation. We do have such certs in the closed area.

Thanks,
Max



More information about the security-dev mailing list