RFR 8180573: Refactor sun/security/tools shell tests to plain java tests

Weijun Wang weijun.wang at oracle.com
Wed Feb 13 03:01:54 UTC 2019


Please review the fix at

   https://cr.openjdk.java.net/~weijun/8180573/webrev.00/

Notes:

- Most changes are just .sh -> .java

- StorePasswordsByShell.sh combined into StorePasswords.java

- In most cases, JarUtils is called to create a jar file. Sometimes the jar command is called because of delicate differences, for example, jar adds directory entries also.

- The i18n tests are completely manual described in i18n.html. Old i18n.java is useless, now is also empty.

- Copyright year updated to 2019, @bug unchanged.

Two files not converted yet:

- ./keytool/console.sh

This is a manual test calling old versions of JDK.

- ./keytool/ListKeychainStore.sh

I tried on this one but "security list-keychains -s ..." has no effect on mach5 machines when calling by ProcessTools. No idea why, I've created a separate bug (JDK-8218886) for it.

Thanks,
Max



More information about the security-dev mailing list