RFR 6913047: SunPKCS11 memory leak

[Valerie Peng]

Hi Martin,

The webrev.15 looks fine to me. The release note is mostly fine, I made 
some minor update to it.

For the CSR, you should finalize it in order for it to be approved. The 
whole process should be explained in the pointer that I sent you 
earlier. I added myself to be the reviewer back in Dec already, so all 
you need to do now is to move the CSR to the "Finalized" state to signal 
that there is no more changes.

In the mean time, which release are you targeting this to? You should 
update the "Fix Version" field of JDK-6913047 to keep various teams 
informed. Also, if this is for JDK 12, you need to watch out for the 
release schedule as RPD2 is fast approaching.

After the CSR is approved, you can proceed with integration. However, 
given the extent of this change, please be really careful with potential 
code conflicts when merging. Double check everything to make sure you 
don't accidentally "undo" others' changes.

Regards,

Valerie

On 1/4/2019 1:25 PM, Martin Balao wrote:
> Hi Valerie,
>
> Is webrev.15 ready for approval? (CSR, patch)
>
> I've re-worked release notes a bit [0].
>
> Thanks,
> Martin.-
>
> --
> [0] - https://bugs.openjdk.java.net/browse/JDK-8215018
>
> On Fri, Dec 7, 2018 at 11:17 AM Martin Balao <mbalao at redhat.com> wrote:
>> Hi Valerie,
>>
>> On Thu, Dec 6, 2018 at 11:27 PM Valerie Peng <valerie.peng at oracle.com>
>> wrote:
>>> I suppose the changes in this update is just the system property
>>> renaming? I looked at the relevant files and they look fine. If you made
>>> more changes than this, please let me know and I will take a closer look
>>> at them.
>> Yes, that's right. No changes other that those related to renaming and
>> documenting the property as requested in the CSR.
>>
>>> Don't forget to add a release note subtask for JDK-6913047 as it has a
>>> "release-note=yes" label.
>> Will do.
>>
>>> I will re-run mach5 with this webrev.15 just to be safe.
>> Thanks,
>> Martin.-