Code Review Request, JDK-8214418 HttpClient falls in running with 100% cpu usage after an error signalled on channel

Chris Hegarty chris.hegarty at oracle.com
Wed Jan 9 14:10:58 UTC 2019


Xuelei,

Is it possible to update the synopsis of this bug to better
reflect the underlying issue ( rather than one particular
symptom )?

Also, it is possible to construct a small, non-HTTP related,
targeted test that verifies the fix?

-Chris.

On 08/01/2019 23:00, Xue-Lei Fan wrote:
> ping ...
> 
> Xuelei
> 
> On 12/22/2018 9:20 AM, Xue-Lei Fan wrote:
>> Hi,
>>
>> Could I get the update reviewed?
>>     http://cr.openjdk.java.net/~xuelei/8214418/webrev.00/
>>
>> The reproducing testing case passed with the update.
>>
>> The issue is caused by the handshake status "NEED_WRAP" while the 
>> connection is half-closed. An application may just call wrap() when 
>> the handshake status is "NEED_WRAP". For compatibility, I changed the 
>> handshake status from NEED_WRAP back to NOT_HANDSHAKING for inbound 
>> half-closed connection.  An application can use 
>> SSLEngine.isOutboundDone() for the determination if SSLEngine.wrap() 
>> should be called.
>>
>> Thanks,
>> Xuelei
>>
>>


More information about the security-dev mailing list