Code Review Request, JDK-8214418 HttpClient falls in running with 100% cpu usage after an error signalled on channel

Daniel Fuchs daniel.fuchs at oracle.com
Wed Jan 9 18:58:12 UTC 2019


Hi Xuelei,

On 22/12/2018 17:20, Xue-Lei Fan wrote:
> The issue is caused by the handshake status "NEED_WRAP" while the 
> connection is half-closed. An application may just call wrap() when the 
> handshake status is "NEED_WRAP". For compatibility, I changed the 
> handshake status from NEED_WRAP back to NOT_HANDSHAKING for inbound 
> half-closed connection.  An application can use 
> SSLEngine.isOutboundDone() for the determination if SSLEngine.wrap() 
> should be called.

For clarification: the logic for the application would be to call
SSLEngine.isOutboundDone(), and if that is false, to call
SSLEngine.wrap() in order to trigger the sending of the close notify
response. Is my understanding correct?

best regards,

-- daniel



More information about the security-dev mailing list