RFR 8217657: Move the test for default value of jdk.includeInExceptions into own test

[Lindenmaier, Goetz]

Thanks!

I should have stated that I don't need a new webrev, thanks anyways.

Best regards,
  Goetz.

> -----Original Message-----
> From: Langer, Christoph
> Sent: Donnerstag, 24. Januar 2019 11:59
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; OpenJDK Dev list
> <security-dev at openjdk.java.net>; OpenJDK Network Dev list <net-
> dev at openjdk.java.net>
> Subject: RE: RFR 8217657: Move the test for default value of
> jdk.includeInExceptions into own test
> 
> Hi Goetz,
> 
> 
> 
> thanks for the review.
> 
> 
> 
> I've added the comment as you suggested:
> http://cr.openjdk.java.net/~clanger/webrevs/8217657.1/
> 
> 
> 
> Will run it through our nightly tests before submitting...
> 
> 
> 
> /Christoph
> 
> 
> 
> 
> 
> From: Lindenmaier, Goetz
> Sent: Donnerstag, 24. Januar 2019 08:48
> To: Langer, Christoph <christoph.langer at sap.com>; OpenJDK Dev list
> <security-dev at openjdk.java.net>; OpenJDK Network Dev list <net-
> dev at openjdk.java.net>
> Subject: RE: RFR 8217657: Move the test for default value of
> jdk.includeInExceptions into own test
> 
> 
> 
> Hi Christoph,
> 
> 
> 
> it is a good idea to keep testing these two matters separately.
> 
> 
> 
> Could you please document in the new test that in OpenJDK
> 
> it is decided to keep this property empty?
> 
> Something like:
> 
> @comment In OpenJDK, this property is empty by default and on purpose. This
> test assures the default is not changed.
> 
> 
> 
> Otherwise, looks good.
> 
> 
> 
> Best regards,
> 
>   Goetz.
> 
> 
> 
> From: net-dev <net-dev-bounces at openjdk.java.net <mailto:net-dev-
> bounces at openjdk.java.net> > On Behalf Of Langer, Christoph
> Sent: Mittwoch, 23. Januar 2019 17:06
> To: OpenJDK Dev list <security-dev at openjdk.java.net <mailto:security-
> dev at openjdk.java.net> >; OpenJDK Network Dev list <net-
> dev at openjdk.java.net <mailto:net-dev at openjdk.java.net> >
> Subject: [CAUTION] RFR 8217657: Move the test for default value of
> jdk.includeInExceptions into own test
> 
> 
> 
> Hi,
> 
> 
> 
> please review a small test update.
> 
> 
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8217657
> 
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8217657.0/
> 
> 
> 
> I'd like to move the test for the correct default value of security property
> "jdk.includeInExceptions" into an own testcase in the jdk.security area. This
> seems a bit more natural than to hide this check in a java/net specific test and
> will help finding/maintaining tests when the (default-)value for that property
> changes. For instance new values get added or other OpenJDK builds have
> different defaults (e.g. SAPMachine).
> 
> 
> 
> Thanks
> 
> Christoph
> 
>