Request for Review [14] JDK-8226976, SessionTimeOutTests uses == operator for String value check
Xuelei Fan
xuelei.fan at oracle.com
Mon Jul 1 16:33:19 UTC 2019
Hi,
In the following test case, "==" is used to compare two strings. As is
not a comment coding convention. I would like to use "equals()" method
instead.
Thanks,
Xuelei
$ hg diff test/jdk/javax/net/ssl/SSLSession/SessionTimeOutTests.java
diff -r 73f1c84ca264
test/jdk/javax/net/ssl/SSLSession/SessionTimeOutTests.java
--- a/test/jdk/javax/net/ssl/SSLSession/SessionTimeOutTests.java
Thu Jun 27 22:03:19 2019 +0200
+++ b/test/jdk/javax/net/ssl/SSLSession/SessionTimeOutTests.java
Mon Jul 01 09:29:23 2019 -0700
@@ -283,7 +283,7 @@
}
System.out.print(sess + " " + lifetime);
if (((timeout == 0) || (lifetime < timeout)) &&
- (isTimedout == "YES")) {
+ isTimedout.equals("YES")) {
isTimedout = "Invalidated before timeout";
}
More information about the security-dev
mailing list