[PATCH] JDK-8226976 - SessionTimeOutTests uses == operator for String value check

Jaikiran Pai jai.forums2013 at gmail.com
Tue Jul 2 05:22:02 UTC 2019


On 02/07/19 7:35 AM, Jaikiran Pai wrote:
> Thank you Xuelei. Here's the updated webrev
> http://cr.openjdk.java.net/~jpai/webrev/8226976/01/webrev/.

- * Copyright (c) 2001, 2017, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2001, 2017, 2019 Oracle and/or its affiliates. All rights reserved.

I just checked some other files within the JDK and can't seem to find a
copyright with more than 2 years listed. So if you meant that I should
change it to "...2001, 2019..." then please do let me know and I'll
update it accordingly and send the updated webrev.

-Jaikiran


>  Updated the
> copyright year and also added you as the reviewer, in the commit log
> message.
>
> -Jaikiran
>
> On 01/07/19 10:17 PM, Xuelei Fan wrote:
>> Hi Jaikiran,
>>
>> Would you mind update the copyright date to 2019?  Otherwise, looks
>> good to me.
>>
>> Thanks,
>> Xuelei
>>
>> On 6/29/2019 6:03 AM, Jaikiran Pai wrote:
>>> While investigating a potential regression in JDK 13+, I happened to use
>>> the test/jdk/javax/net/ssl/SSLSession/SessionTimeOutTests.java. This
>>> test incorrectly uses the == operator for one of the String checks. I
>>> have filed a bug[1] with the details and have a patch with the fix
>>> here[2].
>>>
>>> Can I please get a review and a sponsor for this change?
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8226976
>>>
>>> [2] http://cr.openjdk.java.net/~jpai/webrev/8226976/0/webrev/
>>>
>>> -Jaikiran
>>>
>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/security-dev/attachments/20190702/4c0f8e92/attachment.html>


More information about the security-dev mailing list