RFR[13] JDK-8181386: CipherSpi ByteBuffer to byte array conversion fails for certain data overlap conditions

Xuelei Fan xuelei.fan at oracle.com
Tue Jul 9 03:00:22 UTC 2019

I looked at the code a while back.  The implementation looks good but 
very complicated.  I'm not very sure if the performance benefit really 
worthy it.  I may just simplify it to use temporary buffer if the input 
and output buffer shares the array.  So I was hesitated ...

However, as you are already there,  it may not worthy to re-write the 
fix as well.  ;-) So, it's good to me to have it now.  Please go ahead.


On 7/8/2019 5:24 PM, Valerie Peng wrote:
> Ping...
> May defer this to 14 if no one has cycles to review it.
> Thanks,
> Valerie
> On 6/14/2019 5:19 PM, Valerie Peng wrote:
>> Anyone can help review this fix on ByteBuffer input/output encryption?
>> The fix should be self-explanatory with the comments.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8181386
>> Webrev:http://cr.openjdk.java.net/~valeriep/8181386/webrev.00/ 
>> <http://cr.openjdk.java.net/~valeriep/8181386/webrev.00/>
>> Mach5 run is clean.
>> Thanks,
>> Valerie

More information about the security-dev mailing list